summaryrefslogtreecommitdiffstats
path: root/patches/source/libvpx/0002-encode_api_test-add-ConfigResizeChangeThreadCount.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/source/libvpx/0002-encode_api_test-add-ConfigResizeChangeThreadCount.patch')
-rw-r--r--patches/source/libvpx/0002-encode_api_test-add-ConfigResizeChangeThreadCount.patch89
1 files changed, 89 insertions, 0 deletions
diff --git a/patches/source/libvpx/0002-encode_api_test-add-ConfigResizeChangeThreadCount.patch b/patches/source/libvpx/0002-encode_api_test-add-ConfigResizeChangeThreadCount.patch
new file mode 100644
index 000000000..bd158a235
--- /dev/null
+++ b/patches/source/libvpx/0002-encode_api_test-add-ConfigResizeChangeThreadCount.patch
@@ -0,0 +1,89 @@
+From: James Zern <jzern@google.com>
+Date: Mon, 25 Sep 2023 18:53:41 -0700
+Subject: encode_api_test: add ConfigResizeChangeThreadCount
+Origin: https://github.com/webmproject/libvpx/commit/af6dedd715f4307669366944cca6e0417b290282
+Bug-Debian: https://bugs.debian.org/1053182
+Bug-Debian-Security: https://security-tracker.debian.org/tracker/CVE-2023-5217
+
+Update thread counts and resolution to ensure allocations are updated
+correctly. VP8 is disabled to avoid a crash.
+
+Bug: chromium:1486441
+Change-Id: Ie89776d9818d27dc351eff298a44c699e850761b
+---
+ test/encode_api_test.cc | 50 ++++++++++++++++++++++++++++++++++++++++-
+ 1 file changed, 49 insertions(+), 1 deletion(-)
+
+--- a/test/encode_api_test.cc
++++ b/test/encode_api_test.cc
+@@ -304,7 +304,6 @@ TEST(EncodeAPI, SetRoi) {
+
+ void InitCodec(const vpx_codec_iface_t &iface, int width, int height,
+ vpx_codec_ctx_t *enc, vpx_codec_enc_cfg_t *cfg) {
+- ASSERT_EQ(vpx_codec_enc_config_default(&iface, cfg, 0), VPX_CODEC_OK);
+ cfg->g_w = width;
+ cfg->g_h = height;
+ cfg->g_lag_in_frames = 0;
+@@ -342,6 +341,7 @@ TEST(EncodeAPI, ConfigChangeThreadCount)
+ vpx_codec_ctx_t ctx = {};
+ } enc;
+
++ ASSERT_EQ(vpx_codec_enc_config_default(iface, &cfg, 0), VPX_CODEC_OK);
+ EXPECT_NO_FATAL_FAILURE(
+ InitCodec(*iface, kWidth, kHeight, &enc.ctx, &cfg));
+ if (IsVP9(iface)) {
+@@ -353,6 +353,54 @@ TEST(EncodeAPI, ConfigChangeThreadCount)
+
+ for (const auto threads : { 1, 4, 8, 6, 2, 1 }) {
+ cfg.g_threads = threads;
++ EXPECT_NO_FATAL_FAILURE(EncodeWithConfig(cfg, &enc.ctx))
++ << "iteration: " << i << " threads: " << threads;
++ }
++ }
++ }
++}
++
++TEST(EncodeAPI, ConfigResizeChangeThreadCount) {
++ constexpr int kInitWidth = 1024;
++ constexpr int kInitHeight = 1024;
++
++ for (const auto *iface : kCodecIfaces) {
++ SCOPED_TRACE(vpx_codec_iface_name(iface));
++ if (!IsVP9(iface)) {
++ GTEST_SKIP() << "TODO(https://crbug.com/1486441) remove this condition "
++ "after VP8 is fixed.";
++ }
++ for (int i = 0; i < (IsVP9(iface) ? 2 : 1); ++i) {
++ vpx_codec_enc_cfg_t cfg = {};
++ struct Encoder {
++ ~Encoder() { EXPECT_EQ(vpx_codec_destroy(&ctx), VPX_CODEC_OK); }
++ vpx_codec_ctx_t ctx = {};
++ } enc;
++
++ ASSERT_EQ(vpx_codec_enc_config_default(iface, &cfg, 0), VPX_CODEC_OK);
++ // Start in threaded mode to ensure resolution and thread related
++ // allocations are updated correctly across changes in resolution and
++ // thread counts. See https://crbug.com/1486441.
++ cfg.g_threads = 4;
++ EXPECT_NO_FATAL_FAILURE(
++ InitCodec(*iface, kInitWidth, kInitHeight, &enc.ctx, &cfg));
++ if (IsVP9(iface)) {
++ EXPECT_EQ(vpx_codec_control_(&enc.ctx, VP9E_SET_TILE_COLUMNS, 6),
++ VPX_CODEC_OK);
++ EXPECT_EQ(vpx_codec_control_(&enc.ctx, VP9E_SET_ROW_MT, i),
++ VPX_CODEC_OK);
++ }
++
++ cfg.g_w = 1000;
++ cfg.g_h = 608;
++ EXPECT_EQ(vpx_codec_enc_config_set(&enc.ctx, &cfg), VPX_CODEC_OK)
++ << vpx_codec_error_detail(&enc.ctx);
++
++ cfg.g_w = 16;
++ cfg.g_h = 720;
++
++ for (const auto threads : { 1, 4, 8, 6, 2, 1 }) {
++ cfg.g_threads = threads;
+ EXPECT_NO_FATAL_FAILURE(EncodeWithConfig(cfg, &enc.ctx))
+ << "iteration: " << i << " threads: " << threads;
+ }